locale.c: Reverse order of conditionals #23575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Place the trivial case first; this also removes complementing the conditional. These make it easier to read
khwilliamson
changed the title
bulk88
reviewed
Aug 15, 2025
| if (is_locale_utf8(locale)) { | ||
| locale_utf8ness = LOCALE_IS_UTF8; | ||
| } | ||
| else { |
There was a problem hiding this comment.
maybe drop the curlys for less whitespace/more code on 1 screen for the if()?
Its upto you, I dont have much of an opinion either way.
LOCALE_IS_UTF8 is a const from an enum according to grep, not a STMT_START { thing or a complicated long expression so I dont see a real or paranoia precedence/syntax error hazard here for inserting {} for a 1 liner.
There was a problem hiding this comment.
I have been burned too many times by adding, say, a debugging statement that broke things because I forgot to add braces at the same time.
mauke
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place the trivial case first; this also removes complementing the conditional.
These make it easier to read